Add JUnit5 tests for ClosestSafeSpotTeleport#2828
Merged
tastybento merged 1 commit intodevelopfrom Mar 4, 2026
Merged
Conversation
36 tests covering the Builder, checkLocation(), getChunksToScan(), addChunk(), checkPosition(), scanBlockQueue(), scanAndPopulateBlockQueue(), makeAndTeleport(), gatherChunks(), finishTask(), and asyncTeleport(). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClosestSafeSpotTeleportTestwith 36 tests covering all package-private methods ofClosestSafeSpotTeleportCommonTestSetup; stubsUtil.getChunkAtAsyncwith a never-completing future so tests control async flow explicitlyTest plan
checkLocation()fast-path vs full scan branchinggetChunksToScan()returns non-empty, duplicate-free listaddChunk()island space filtering and duplicate preventioncheckPosition()portal and non-portal modes, noPortalPosition handlingscanBlockQueue()empty and non-empty casesscanAndPopulateBlockQueue()bounding-box filteringmakeAndTeleport()correct material placed per environmentgatherChunks()checking-flag guard, exhausted iterator, early-finish on close candidatefinishTask()task cancellation, success path, portal fallback, cancelIfFail pathasyncTeleport()success runnable dispatch and future completion./gradlew test --tests "world.bentobox.bentobox.util.teleport.ClosestSafeSpotTeleportTest")🤖 Generated with Claude Code