Skip to content

Backport 2.7.1 crash fixes: macOS 26 WebView UAF + MakerWorld 3MF NULL-deref #489

@BenJule

Description

@BenJule

Backport the two 2.7.1 crash fixes I submitted upstream so fork users on the 2.7.1 base get them too.

1. macOS 26.5 WebView use-after-free (upstream bambulab bambulab#11004 / bambulab#10968, PR bambulab#11052)

WebView::CreateWebView registers the script handler from a CallAfter() callback that captures the raw wxWebView*. On macOS 26.5+ the view can be destroyed before the async callback fires → use-after-free → PAC crash on Apple Silicon / long startup hang. Fix: guard the callback against an already-destroyed view + clean up g_delay_webviews in ~WebViewRef.

2. MakerWorld 3MF NULL-deref (upstream bambulab bambulab#11016 / bambulab#11037, PR bambulab#11053)

GLVolumeCollection::load_object_volume dereferences instances[instance_idx] without checking; an object with no instances (some MakerWorld 3MFs, opened via the object-color dialog) crashes in instance->get_transformation(). Fix: defensive guard at the top of load_object_volume.

Both verified upstream; this brings them into the fork via develop.

Metadata

Metadata

Assignees

Labels

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions