refactor: convert traits tests to use fixtures #1774
Merged
+96
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acoulton
approved these changes
Dec 10, 2025
Contributor
acoulton
left a comment
There was a problem hiding this comment.
Brilliant work @carlos-granados - thanks for all the effort on all of these!
You have definitely earned a beer / cake / reward of your choice 🥳
ed6e296 to
8a9789d
Compare
Contributor
|
Once you've merged this I'll prepare a release (probably tomorrow) with all the recent changes. Then I'll update and merge #1763 with the strict return types and we can release it as a standalone release so that it's easy for people to roll back / past it if there's any issues with it (not that I expect any). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last test that needed to be converted to use fixtures! 🎉