refactor: convert rerun multiple suite tests to use fixtures #1771
+192
−214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5785a6 to
485bbc2
Compare
acoulton
reviewed
Dec 9, 2025
| Scenario: Fixing scenarios removes it from the rerun log | ||
| Given I run "behat --no-colors -f progress features/apples.feature" | ||
| And there is a file named "features/bananas.feature" with: | ||
| Given I run "behat features/apples.feature" |
Contributor
There was a problem hiding this comment.
I'm not sure I follow why we run only the apples feature, then immediately copy the bananas-fixed feature over the top of the bananas feature (without ever having run the bananas feature) and then run both features?
Contributor
Author
There was a problem hiding this comment.
The original test was like this buy yeah, agree that it does not make much sense. I have updated it so that the first step runs both features, I think it makes much more sense like that
… rerun log' scenario
acoulton
approved these changes
Dec 10, 2025
Contributor
acoulton
left a comment
There was a problem hiding this comment.
Thanks @carlos-granados yeah, I saw that was how the original feature did it. It's much clearer now.
Thanks for driving all this forward - it makes it so much easier to understand what we are actually testing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests also re-use the fixtures in the
Rerunfolder. The context file has been modified a little so we have needed to modify existing tests a little bit as well