Skip to content

Conversation

@carlos-granados
Copy link
Contributor

No description provided.

When I run "behat --config=behat-hyphens.php --format progress --suite suite-with-hyphens"
Then it should pass with:
"""
No scenarios
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This obviously matches the original, but it doesn't necessarily prove that we have actually correctly matched the suite-with-hyphens suite name.

Particularly since we don't appear to have any coverage that it fails with an error if you specify a suite name that does not exist. We could theoretically be falling back to the first / default / all suites in this situation (we're not, but that could change in the future).

I think it might actually be viable to just rename the second suite in the existing behat-two-features.php config file to suite-with-hyphens and just reuse those examples to prove that we've selected the correct features to run. I don't think any of the other scenarios here depend on the naming of that suite.

Equally, these are quite minor/theoretical concerns so feel free to ignore & move on!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I see what you mean. I modified the configuration for this suite so that it actually runs some tests and then confirmed that they were run

Copy link
Contributor

@acoulton acoulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlos-granados carlos-granados merged commit 63bc7b8 into Behat:3.x Dec 10, 2025
22 checks passed
@carlos-granados carlos-granados deleted the refactor-suite-tests branch December 10, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants