refactor: convert snippets tests to use fixtures #1768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8f1b84c to
4f00aab
Compare
carlos-granados
commented
Dec 10, 2025
| $this->answerString = $answerString; | ||
|
|
||
| $this->options = '--format-settings=\'{"timer": false}\''; | ||
| $this->options = '--no-colors --format-settings=\'{"timer": false}\''; |
Contributor
Author
There was a problem hiding this comment.
This step overrides any option set for behat previously, so we need to make sure that it uses the no-colors option
Contributor
There was a problem hiding this comment.
Makes sense - but would it be clearer if it didn't override the options (so it behaves consistently with the normal "I run Behat" step? I suppose that might impact on other scenarios that are depending on this behaviour, so we could leave it for now,
acoulton
approved these changes
Dec 10, 2025
Contributor
acoulton
left a comment
There was a problem hiding this comment.
Thanks @carlos-granados one small comment / query but happy with it as-is if you are.
4f00aab to
2f48be4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.