refactor: convert syntax_help tests to use fixtures #1765
Conversation
5a22388 to
c72b534
Compare
c72b534 to
6143c22
Compare
| // Remove indentation | ||
| $description = preg_replace('/^[\s\t]*/m', '', $docBlock); | ||
|
|
||
| // normalize line endings |
There was a problem hiding this comment.
While running the tests in CI I discovered that the actual output was different in Windows machines. This had been hidden by the manipulation of line endings that we do on the tests but when using fixtures it became noticeable. The issue is that we later split this description into lines by a newline character, so we need to normalize the line endings in Windows in order for this functionality to behave equally in all OSs
There was a problem hiding this comment.
Good catch, thanks @carlos-granados.
It would be worth mentioning this change in the commit message when it's merged (though it should make no external difference, as you say I can see that we later explode by "\n" and then print each line using the system line ending).
There was a problem hiding this comment.
Added a comment in the extended description of the commit
acoulton
left a comment
There was a problem hiding this comment.
Thanks @carlos-granados
No description provided.