refactor: Resolve symfony/console deprecation in 7.4, fix phpstan #1757
+21
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symfony/console 7.4.0 deprecates the `Application::add` method in favour of a new `Application::addCommand` method. `Application::add` is then removed in 8.0. We had a fix for this in the 4.0 branch, but it started to cause phpstan errors once symfony 8.0 was released & installed for the phpstan job. Additionally, the errors varied depending on the symfony version installed. This fix bumps us off the deprecated method for Behat 3.x and symfony >= 7.4.0. It also updates the phpstan ignore to cover all supported symfony versions.
acoulton
commented
Dec 7, 2025
| - src/Behat/Testwork/Ordering/Cli/OrderController.php | ||
| - | ||
| # BC wrapper for symfony/console < 7.4.0 | ||
| message: '#method_exists.+ ''(add|addCommand)'' will always evaluate to (true|false)#' |
Contributor
Author
There was a problem hiding this comment.
I have intentionally left out the identifier as it varies between symfony version installed (function.impossibleType if the method is not present, function.alreadyNarrowedType if it is).
acoulton
commented
Dec 7, 2025
| } | ||
|
|
||
| // Otherwise assert we are on an older version with `add` and call that. | ||
| assert(method_exists($this, 'add')); |
Contributor
Author
There was a problem hiding this comment.
This is the main functional difference to the patch in the 4.x branch - that was just using a ternary:
Behat/src/Behat/Testwork/Cli/Application.php
Line 130 in a430241
But of course there is no guarantee that add exists just because addCommand does not, so once 8.0 was actually released (and therefore installed in the phpstan build) it reported that the add method does not exist. Asserting here avoids that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
symfony/console 7.4.0 deprecates the
Application::addmethod in favour of a newApplication::addCommandmethod.Application::addis then removed in 8.0.We had a fix for this in the 4.0 branch, but it started to cause phpstan errors once symfony 8.0 was released & installed for the phpstan job. Additionally, the errors varied depending on the symfony version installed.
This fix bumps us off the deprecated method for Behat 3.x and symfony >= 7.4.0. It also updates the phpstan ignore to cover all supported symfony versions.