refactor: convert helper_containers.feature to use fixtures #1730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a5311b9 to
db187b7
Compare
- Moved all inline file creation to tests/Fixtures/HelperContainers/ - Created 7 PHP config files for different container scenarios - Created context and service classes with proper PSR-12 formatting - Updated feature file to use fixtures with Background section - Changed format to pretty and added expected output for all scenarios - All 7 scenarios passing
db187b7 to
2e30ccb
Compare
acoulton
reviewed
Dec 1, 2025
Comment on lines
+10
to
+14
| 'services' => [ | ||
| 'shared_service' => [ | ||
| 'class' => 'SharedService', | ||
| ], | ||
| ], |
Contributor
There was a problem hiding this comment.
I've opened #1732 for a future enhancement to add service configuration to our PHP config objects.
acoulton
approved these changes
Dec 1, 2025
Contributor
acoulton
left a comment
There was a problem hiding this comment.
Great, thanks @carlos-granados
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.