refactor: migrate extension_inheritance.feature to use fixtures #1727
+205
−162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acoulton
requested changes
Nov 30, 2025
| | --profile | custom_profile | | ||
| | -vvv | | | ||
| | features/extensions-disabled.feature | | | ||
| Then it should pass |
Contributor
There was a problem hiding this comment.
I think this is another where it'd be good to add expected output here so we're confident the config / profile has been triggered as expected (also helps to describe what the feature does now that the files are all moved to the fixture)?
cca81fc to
c1ee530
Compare
acoulton
approved these changes
Dec 1, 2025
Contributor
acoulton
left a comment
There was a problem hiding this comment.
Thanks @carlos-granados , really helpful to have that extra detail in the feature.
c1ee530 to
e18483a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.