Skip to content

Conversation

@carlos-granados
Copy link
Contributor

No description provided.

@carlos-granados carlos-granados merged commit 1ae45c0 into Behat:3.x Nov 29, 2025
21 checks passed
@carlos-granados carlos-granados deleted the refactor-dry-run branch November 29, 2025 13:33
@acoulton
Copy link
Contributor

acoulton commented Dec 4, 2025

@carlos-granados took me a moment this morning to work out why 4.x was failing on the Stringable cs-fixer rules when 3.x was OK, as I hadn't seen a fix go through for it in 3.x. It looks like you fixed that in this branch after I'd reviewed it - not a big issue (it's just making an implicit interface explicit), but we probably should have updated the PR title / included that in the merge commit information.

@carlos-granados
Copy link
Contributor Author

Yes, sorry, I should have done that, it was just late at night and wanted to get through with it, apologies

@acoulton
Copy link
Contributor

acoulton commented Dec 4, 2025

No worries, I just was a bit confused at first and couldn't work out if it was just because it was the morning 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants