Fix static analysis in PHP 8.5 #1719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decb1c7 to
296584c
Compare
acoulton
approved these changes
Nov 28, 2025
Contributor
acoulton
left a comment
There was a problem hiding this comment.
Thanks for figuring this out - I can't think of a better solution. Just a small comment on the cs-fixer config.
.php-cs-fixer.dist.php
Outdated
| ], | ||
| 'single_line_throw' => false, //override Symfony | ||
| 'yoda_style' => false, //override Symfony | ||
| 'phpdoc_to_comment' => false, //incorrectly changes @var tags |
Contributor
There was a problem hiding this comment.
It might be better to just exclude the specific tag we want to keep?
Suggested change
| 'phpdoc_to_comment' => false, //incorrectly changes @var tags | |
| 'phpdoc_to_comment' => [ // Keep as a phpdoc if it contains the `@var` annotation | |
| 'ignored_tags' => ['var'], | |
| ], |
Contributor
Author
There was a problem hiding this comment.
Ah, did not known about that option, updated!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest versions of the Symfony Config component improve the docs for some of the functions on the config objects and now use Template tags so that PHPStan is able to correctly guess the type returned. So some asserts are not needed any more. But they are still needed in older versions of Symfony which don't have these improved docs. The only solution I was able to find was to change these asserts into @var tags, this seems to work for both versions
Had to disable a PHP-CS-Fixer rule which was incorrectly trying to change these @var tag docblocks into normal comments