Skip to content

Conversation

@acoulton
Copy link
Contributor

@carlos-granados @stof I've added sponsorship links and some readme text in line with #1695

I think it might be most logical to put the funding links in alphabetical order. But I wasn't totally comfortable doing that as someone with an "a" name 😆 It'd be nice if Github would randomise the order over time but I don't think they do...

So I ran the names through a random shuffle and have them in different orders in the composer.json and funding.yml. If we go with that, I can shuffle them again for the files in Behat/Gherkin...

Let me know what you think

Copy link
Contributor

@carlos-granados carlos-granados left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @acoulton, looking great

@acoulton
Copy link
Contributor Author

@stof just wanted to check you're also happy with this? Thanks

@stof
Copy link
Member

stof commented Dec 1, 2025

You could reduce the number of places where the list of maintainers has to be maintained. The GitHubDriver of composer supports reading the .github/FUNDING.yml file (or the FUNDING.yml file) in the default branch of the repo where there is no explicit funding key in the composer.json.

@acoulton
Copy link
Contributor Author

acoulton commented Dec 1, 2025

Ahh, that's useful to know, thanks!

I'll do that later and then we can get this merged.

@acoulton acoulton merged commit 6af6219 into Behat:3.x Dec 2, 2025
21 checks passed
@acoulton acoulton deleted the add-funding branch December 2, 2025 09:08
@acoulton
Copy link
Contributor Author

acoulton commented Dec 2, 2025

That's showing now on https://github.com/Behat/Behat and when you run composer fund:
image

It appears that composer alpha-sorts the funding links, however GitHub shows them in the order they appear in the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants