chore: Replace friendsofphp/php-cs-fixer by php-cs-fixer/shim #1701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids dependency conflicts with other packages.
carlos-granados
requested changes
Nov 24, 2025
composer.json
Outdated
| "symfony/process": "^5.4 || ^6.4 || ^7.0", | ||
| "symfony/filesystem": "^5.4 || ^6.4 || ^7.0" | ||
| "symfony/filesystem": "^5.4 || ^6.4 || ^7.0", | ||
| "php-cs-fixer/shim": "^3.89" |
Contributor
There was a problem hiding this comment.
I think it is good to keep this list sorted (though I can see that this was already broken with symfony/filesystem) Can you please change this so that the list is sorted?
Contributor
Author
There was a problem hiding this comment.
Good catch - I've configured composer to sort packages and re-sorted the requires accordingly.
stof
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using php-cs-fixer/shim avoids us having any restrictions from php-cs-fixer's own dependency constraints.
This was initially included in #1687 by @Kocal as it was required to allow us to install Symfony 8 ahead of php-cs-fixer adding support.
I've extracted to a separate PR for the 3.x series - we might as well switch now to reduce merge conflicts or any other dependency constraints in future.