Update the pretty printer to handle future gherkin tag behavior #1690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The legacy mode of the gherkin parser was trimming the `@` sign from tags when building the AST, so the pretty printer was prepending it back. As the upstream cucumber gherkin AST preserve the `@` sign in tags, future versions of the behat/gherkin parser will preserve it as well.
acoulton
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The legacy mode of the gherkin parser was trimming the
@sign from tags when building the AST, so the pretty printer was prepending it back.As the upstream cucumber gherkin AST preserve the
@sign in tags, future versions of the behat/gherkin parser will preserve it as well.Refs Behat/Gherkin#336
Refs #1645
The pretty printer can handle that case by detecting the format of the tag, without any need of knowing the compatibility mode used by the parser.
Note that the filtering by tags is not updated in this PR because the implementation of the filter is done in behat/gherkin, not in this repo.