fix: Exit with correct exit code on sigint #1686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exit codes for fatal signals is typically 128 + the signal number. For SIGINT, whose number is 2, it should be 130. https://www.gnu.org/software/bash/manual/html_node/Exit-Status.html
Contributor
Author
|
Hitting Ctrl+C shoudl give an exit code of 130. |
acoulton
requested changes
Nov 5, 2025
Contributor
acoulton
left a comment
There was a problem hiding this comment.
Thanks @andrewnicols - this looks good, just a small comment on BC impact.
acoulton
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exit codes for fatal signals is typically 128 + the signal number.
For SIGINT, whose number is 2, it should be 130.
https://www.gnu.org/software/bash/manual/html_node/Exit-Status.html