Fix php version constraint in composer.json #1678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I suggest also opening an issue on php-cs-fixer so they might be aware of this. |
stof
approved these changes
Oct 23, 2025
Contributor
|
Thanks @carlos-granados
I agree with @stof, it does feel like a php-cs-fixer bug if they can't parse a valid composer constraint. That said I think the way you've expressed the constraint is much clearer to read anyway so it's a good change to have. |
Contributor
Author
|
@stof @acoulton issue opened PHP-CS-Fixer/PHP-CS-Fixer#9165 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of php-cs-fixer showed a warning saying
"Unable to determine minimum supported PHP version from composer.json: Invalid version string "8.1.*""
It seems that, though composer was able to understand our constraint, php-cs-fixer wasn't
I updated it to use a new constraint that should be understood by everyone