Skip to content

Conversation

@acoulton
Copy link
Contributor

@acoulton acoulton commented Oct 2, 2025

No description provided.

CHANGELOG.md Outdated

### Internal
* Remove PHP 8 error conversion by @carlos-granados in [#1665](https://github.com/Behat/Behat/pull/1665)
* Apply Rector rules to use PHP 8.1+ language features by @carlos-granados in [#1666](https://github.com/Behat/Behat/pull/1666)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should not be PHP 8.1+, we are not using any feature above 8.1 level

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I see how that's confusing. I'd meant it as "language features that work on >= 8.1" but you're right it's much clearer to just say "8.1". Fixed now

Copy link
Contributor

@carlos-granados carlos-granados left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny comment

Copy link
Contributor

@carlos-granados carlos-granados left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @acoulton

@acoulton acoulton merged commit bc7f149 into Behat:master Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants