fix: Provide more context when failing with unexpected multiline args #1668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
936afc9 to
af309a6
Compare
stof
reviewed
Oct 2, 2025
| r | ||
| <word2> | ||
| d | ||
| """ No newline at end of file |
Member
There was a problem hiding this comment.
I suggest adding the fine LF in all those feature files.
Contributor
Author
There was a problem hiding this comment.
Good catch, thanks - I'd just captured them from the previous inline strings and hadn't noticed they were missing.
This was referenced Oct 2, 2025
af309a6 to
8bdd342
Compare
So that it's easier to run individual examples and see the actual output, and to have completion etc for them.
Because of the stage where it is thrown, the exception is treated as an overall fatal error. This meant that Behat does not output any detail on the feature file / step it was parsing when it encountered the unexpected argument. As a result, users had no information on the cause of the error and would have to check their features / steps manually. Instead, include the name of the function and (where possible) the feature and step within the exception message. This will still mean that users have to fix these one at a time (Behat will exit on the first such exception) but they should at least now be able to locate the issue.
8bdd342 to
add8457
Compare
carlos-granados
approved these changes
Oct 2, 2025
Contributor
carlos-granados
left a comment
There was a problem hiding this comment.
@acoulton great stuff, thanks for fixing this (and converting the tests at the same time 😄 )
Contributor
|
Thanks @acoulton for this fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the stage where it is thrown, the exception is treated as an overall fatal error. This meant that Behat does not output any detail on the feature file / step it was parsing when it encountered the unexpected argument. As a result, users had no information on the cause of the error and would have to check their features / steps manually.
Instead, include the name of the function and (where possible) the feature and step within the exception message. This will still mean that users have to fix these one at a time (Behat will exit on the first such exception) but they should at least now be able to locate the issue.
As reported by @AlexSkrypnyk in #1614 (comment)