Rector php sets #1666
Merged
Rector php sets #1666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6240911 to
6aa2349
Compare
acoulton
approved these changes
Sep 27, 2025
Contributor
acoulton
left a comment
There was a problem hiding this comment.
Thanks @carlos-granados, I've had a good look over these and all LGTM. Thanks for breaking it into separate commits, that made it much easier :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies all Rector rules related to our PHP "language level" to upgrade our code to use all language features available until PHP 8.1.
The PR has been divided in a number of commits which apply one or a few rules to make it easier to review. There are a couple of very large commits but in those commits the changes are all very similar so I believe it should be easy to review