chore: Relax constraint on composer/xdebug-handler #1649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These will allow users to upgrade to newer Behat versions even if they have a dependency that is holding back their composer/xdebug-handler version. * 1.4.0 adds support for PHP 8 and is therefore the minimum we can allow * 2.x has API changes, but none that affect the methods we are calling * 3.x only drops support for old PHP and adds strict types Therefore, it should be safe to accept all of these versions. Note, however, that we have no easy way to test this in CI due conflicts with our own dev dependencies, and because the main Behat process disables xdebug and persists this config to children - so cannot easily run child Behat processes with xdebug enabled.
stof
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These will allow users to upgrade to newer Behat versions even
if they have a dependency that is holding back their
composer/xdebug-handler version.
Therefore, it should be safe to accept all of these versions.
Refs #1637
Testing
We do not currently have any feature / test coverage for the "disable xdebug" feature.
I structured a feature that could prove it was working as expected, and have run that manually / locally with the latest 1.4.x, 2.x and 3.x versions.
For testing in CI we have two issues:
First, our dev dependency on
friends-of-php/php-cs-fixerrequirescomposer/xdebug-handler:^3.0.3. This makes it a bit complex to set up matrix jobs that can install the 1.4.x or 2.x versions.Second, our main Behat process automatically disables xdebug. This setting is persisted to child processes by xdebug-handler (which writes temporary .ini files, then modifies the env vars to read them). Therefore there's no way to prove whether the
--xdebugcommand line argument does anything, because the child Behat processes we run will always start with xdebug disabled.I don't think we want to enable xdebug for all of our features, so the only thing I can think of would be to run a totally separate Behat process (e.g. as a new step in the job) just to prove the xdebug behaviour - but that again feels quite complex for what this is?