Do not disable xdebug if there is an active debugging connection #1581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested, fixes my issue |
Contributor
Author
|
@acoulton given that some users have been affected by this, I thought that perhaps we could release this change as a patch release with only this fix, instead of waiting for a regular release. What do you think? |
Contributor
|
@carlos-granados we could do - but looking at v3.17.0...master I don't think there's really anything controversial there to specifically require a separate 3.17.1 with just this change. So maybe we just merge this and do a 3.18.0 (which would be simplest)? |
Contributor
Author
|
@acoulton ok, let's go ahead with a 3.18 release. Can you prepare it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following @stof 's suggestion in #1577 in this PR we check if there is an active Xdebug session, and if there is, we don't disable it, even if no
--xdebugflag has been passed