fix: allow using the narrative filter on the command line #1559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acoulton
reviewed
Dec 6, 2024
Contributor
acoulton
left a comment
There was a problem hiding this comment.
Great, just a question on option descriptions
| ) | ||
| ->addOption( | ||
| '--narrative', null, InputOption::VALUE_REQUIRED, | ||
| "Only executeCall the features with actor description" . PHP_EOL . |
Contributor
There was a problem hiding this comment.
Is Only executeCall the... here intentional (I realise it's in the existing descriptions too)? On first read it looks odd, should it just be Only execute the...?
Contributor
Author
There was a problem hiding this comment.
I just copied and pasted without paying much attention to the text, but you are right that this reads weird, updated
5ad721b to
94cfa9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at the PR that added the filters to the PHP config I noticed that the narrative filter had not been added as the filters that could be run from the command line. It was also missing from one error message.
I also found that there was no test for running the role filter from the command line
This PR addresses all these issues