-
-
Notifications
You must be signed in to change notification settings - Fork 616
PHP Config - suite filters #1557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP Config - suite filters #1557
Conversation
|
@acoulton @carlos-granados |
acoulton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I think I'd stick with ->withFilter() - there will often only be one, or at most a very short list, and in time we might want to add helpers like e.g. (new TagFilter())->include('ui')->exclude('php84') which would be neatest if each filter was in a separate method call.
Agreed |
carlos-granados
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one comment
| ], $config->toArray()); | ||
| } | ||
|
|
||
| public function testAddingFilters(): void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are missing the test to confirm that you cannot repeat a filter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
d3fc8ef to
487d815
Compare
carlos-granados
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @loic425
I'm wondering if we should implement
withFilters(FilterInterface ...$filters)instead.But for now, we have implemented them like this on Profile.