DX: better output for wrong status code or unexpected output #1532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0cf9ad8 to
1a0e195
Compare
carlos-granados
requested changes
Nov 13, 2024
Contributor
carlos-granados
left a comment
There was a problem hiding this comment.
Mostly looking good, just a few tiny comments
acoulton
approved these changes
Nov 15, 2024
Contributor
acoulton
left a comment
There was a problem hiding this comment.
@jdeniau thanks - this looks great and will be very helpful, I don't have anything to add to @carlos-granados changes
1a0e195 to
da1b465
Compare
da1b465 to
47f212b
Compare
Contributor
Author
|
@carlos-granados this is updated |
carlos-granados
approved these changes
Nov 15, 2024
Contributor
carlos-granados
left a comment
There was a problem hiding this comment.
Thanks @jdeniau !
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1522
Then it should pass/fail with: + expected status code + wrong output
Then it should pass/fail with: + wrong status code + wrong output
Then it should pass/fail with: + wrong status code + expected output
Then the output should contain with unexpected value
Then it should pass/fail