Updated create-dmg from upstream#10
Merged
cfabianski merged 1 commit intoBearer:mainfrom Apr 10, 2024
Merged
Conversation
This was referenced Feb 26, 2024
Contributor
|
Thanks @dylanratcliffe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the alternate PR to #9
Instead of patching the script we're just pulling the upstream which contains a fix for the apple silicon issue along with lots of new updates. As you can see it requires a slight change to the tests since some files that were expected to exist aren't there anymore. We also need to make sure that we package the
.this-is-the-create-dmg-repofile so thatcreate-dmgknows where to look for itssupportfolder