refactor: optimize string operations and improve code clarity#451
Merged
WiserTixx merged 2 commits intoBeamMP:minorfrom Jan 1, 2026
Merged
refactor: optimize string operations and improve code clarity#451WiserTixx merged 2 commits intoBeamMP:minorfrom
WiserTixx merged 2 commits intoBeamMP:minorfrom
Conversation
WiserTixx
requested changes
Dec 27, 2025
- Avoid redundant substr() calls in packet parsing hot-path (TServer.cpp) The previous code called substr(3) twice per packet, creating unnecessary temporary strings. Now stores the result once. - Replace .size() == 0 with .empty() for idiomatic C++ (TConsole.cpp, TLuaEngine.cpp)
402e4b8 to
b74f0c7
Compare
Collaborator
|
Is there any reason why you didn't use the pull request template? |
Contributor
Author
I didn't even notice there was a template. |
WiserTixx
approved these changes
Jan 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid redundant substr() calls in packet parsing hot-path (TServer.cpp)
The previous code called substr(3) twice per packet, creating
unnecessary temporary strings. Now stores the result once.
Replace .size() == 0 with .empty() for idiomatic C++
(TConsole.cpp, TLuaEngine.cpp)