CMake updates for kdecoration#293
Merged
Bali10050 merged 2 commits intoBali10050:feature-testingfrom Feb 27, 2026
Merged
Conversation
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added a few extra CMake variables to capture the version info of
kdecorationSlight adjustments to the darklydecoration code so that If the version >=6.5.0 then continue to use all the existing radius code introduced for the rounded bottom corners. On Kubuntu it will be skipped since it is not supported in lower versions.
On Kubuntu shown below, the option for rounded bottom corners is disabled by default.
https://invent.kde.org/plasma/breeze/-/blob/master/kdecoration/CMakeLists.txt#L26
include(GNUInstallDirs)from CMakeLists.txt as this was showing the following warnings:and aligned with upstream who don't have that:
https://invent.kde.org/plasma/breeze/-/blob/master/CMakeLists.txt?ref_type=heads#L13