Allowing netspec to have empty top (ntop=0) #2741
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
python/caffe/net_spec.py
Outdated
Member
There was a problem hiding this comment.
Add two newlines for pep8itude.
Contributor
Author
There was a problem hiding this comment.
hmm that pep8... done.
Member
|
Looks good to me but @longjon should check. |
b164b7c to
f640ff1
Compare
Contributor
|
Thanks for PRing this. I have a rather simpler implementation myself, so stay tuned. |
Contributor
Author
|
Simpler than 20 line changes? :) |
Contributor
|
See longjon@b464a6e, and preparations in longjon@96c2fe1. |
Contributor
Author
|
#2813 seems to be functionally the same, at least for what I'm using it for. So I don't have any objections going with the other solution, even though it's 50 line changes :) |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just as it says, allows specification of layers with empty tops (eg Silence, HDF5Output).