Add error checking for image mean #1931
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
@lukeyeager ha this was actually my check for just this but I accidentally commented it out. Your checks cover more cases though so when I merge I'll combine them so please switch to exceptions for merge.
Member
|
Could you update this PR to |
Contributor
Author
|
Sure thing. |
When setting the mean, assert that it is either one pixel or an array with shape equal to the input data size.
Contributor
Author
|
Closing due to inactivity. I'll rebase and move this to a different branch for the sake of sanity in my repo, then repost. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting the mean, assert that it is either one pixel or an array with shape equal to the input data size.
Helps others who run into #1928 by giving them a meaningful error message.