Skip to content

Fix CMake Python IPO Control#5055

Merged
ax3l merged 1 commit intoBLAST-WarpX:developmentfrom
ax3l:fix-py-ipo-cmake
Jul 17, 2024
Merged

Fix CMake Python IPO Control#5055
ax3l merged 1 commit intoBLAST-WarpX:developmentfrom
ax3l:fix-py-ipo-cmake

Conversation

@ax3l
Copy link
Copy Markdown
Member

@ax3l ax3l commented Jul 17, 2024

pybind11::lto is only defined if CMAKE_INTERPROCEDURAL_OPTIMIZATION is not set in pybind11Common.cmake. Package managers like Spack use the latter.

@ax3l ax3l added bug Something isn't working bug: affects latest release Bug also exists in latest release version component: Python Python layer labels Jul 17, 2024
@ax3l ax3l requested a review from EZoni July 17, 2024 00:03
@ax3l ax3l mentioned this pull request Jul 17, 2024
1 task
@ax3l ax3l force-pushed the fix-py-ipo-cmake branch 2 times, most recently from ab568a1 to d6ba0fa Compare July 17, 2024 22:02
`pybind11::lto` is only defined if `CMAKE_INTERPROCEDURAL_OPTIMIZATION`
is not set in `pybind11Common.cmake`. Package managers like Spack
use the latter.
@ax3l ax3l force-pushed the fix-py-ipo-cmake branch from d6ba0fa to 3db8f0c Compare July 17, 2024 22:26
@ax3l ax3l enabled auto-merge (squash) July 17, 2024 22:53
@ax3l ax3l disabled auto-merge July 17, 2024 23:19
@ax3l ax3l merged commit b58343a into BLAST-WarpX:development Jul 17, 2024
@ax3l ax3l deleted the fix-py-ipo-cmake branch July 17, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: affects latest release Bug also exists in latest release version bug Something isn't working component: Python Python layer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants