Skip to content

Fix CMake Python IPO Control#644

Merged
ax3l merged 1 commit intoBLAST-ImpactX:developmentfrom
ax3l:fix-py-ipo-cmake
Jul 17, 2024
Merged

Fix CMake Python IPO Control#644
ax3l merged 1 commit intoBLAST-ImpactX:developmentfrom
ax3l:fix-py-ipo-cmake

Conversation

@ax3l
Copy link
Copy Markdown
Member

@ax3l ax3l commented Jul 17, 2024

pybind11::lto is only defined if CMAKE_INTERPROCEDURAL_OPTIMIZATION is not set in pybind11Common.cmake. Package managers like Spack use the latter.

@ax3l ax3l added bug Something isn't working bug: affects latest release Bug also exists in latest release version install component: python Python bindings labels Jul 17, 2024
@ax3l ax3l mentioned this pull request Jul 17, 2024
1 task
@ax3l ax3l force-pushed the fix-py-ipo-cmake branch from 4fa50c3 to 63de713 Compare July 17, 2024 22:00
`pybind11::lto` is only defined if `CMAKE_INTERPROCEDURAL_OPTIMIZATION`
is not set in `pybind11Common.cmake`. Package managers like Spack
use the latter.
@ax3l ax3l force-pushed the fix-py-ipo-cmake branch from 63de713 to 2b00d70 Compare July 17, 2024 22:26
@ax3l ax3l requested a review from EZoni July 17, 2024 22:27
@ax3l ax3l enabled auto-merge (squash) July 17, 2024 22:53
@ax3l ax3l merged commit 311621f into BLAST-ImpactX:development Jul 17, 2024
@ax3l ax3l deleted the fix-py-ipo-cmake branch July 18, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: affects latest release Bug also exists in latest release version bug Something isn't working component: python Python bindings install

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants