Skip to content
This repository was archived by the owner on May 13, 2025. It is now read-only.

Reverting changes for extensions type api#249

Merged
Arif-lakhani merged 2 commits intok8s-extension/publicfrom
revertextensionstype
Aug 23, 2023
Merged

Reverting changes for extensions type api#249
Arif-lakhani merged 2 commits intok8s-extension/publicfrom
revertextensionstype

Conversation

@Arif-lakhani
Copy link
Copy Markdown


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link
Copy Markdown

@bavneetsingh16 bavneetsingh16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Arif-lakhani Arif-lakhani enabled auto-merge August 23, 2023 21:48
@Arif-lakhani Arif-lakhani merged commit 6be2701 into k8s-extension/public Aug 23, 2023
@Arif-lakhani Arif-lakhani deleted the revertextensionstype branch August 23, 2023 21:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants