Skip to content

Updated Id Web to use lang version 11 across repo#2359

Merged
FuPingFranco merged 3 commits into
masterfrom
francofung/updating_lang_version
Aug 2, 2023
Merged

Updated Id Web to use lang version 11 across repo#2359
FuPingFranco merged 3 commits into
masterfrom
francofung/updating_lang_version

Conversation

@FuPingFranco

@FuPingFranco FuPingFranco commented Jul 31, 2023

Copy link
Copy Markdown
Contributor

Update C# lang version to 11

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

Updated lang version to use 11 across Id Web repo.

Fixes #2351

@FuPingFranco FuPingFranco linked an issue Jul 31, 2023 that may be closed by this pull request

@jmprieur jmprieur left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some settings are not needed

Comment thread tests/Directory.Build.props
Comment thread tools/app-provisioning-tool/Directory.Build.props
Comment thread tests/DevApps/aspnet-mvc/OwinWebApi/OwinWebApi.csproj
Comment thread tests/DevApps/daemon-app/Daemon-app/Daemon-app.csproj

@jennyf19 jennyf19 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

Comment thread tests/DevApps/aspnet-mvc/OwinWebApi/OwinWebApi.csproj
@jennyf19

jennyf19 commented Aug 1, 2023

Copy link
Copy Markdown
Collaborator

Is this all updated now @FuPingFranco ?

@FuPingFranco

Copy link
Copy Markdown
Contributor Author

Is this all updated now @FuPingFranco ?

Yes, It is now I forgot to update this as I was working on the nullables my apologies.

@jennyf19 jennyf19 reopened this Aug 1, 2023

@jmprieur jmprieur left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @FuPingFranco

@FuPingFranco FuPingFranco merged commit e9e015e into master Aug 2, 2023
@jennyf19 jennyf19 added this to the 2.13.3 milestone Aug 2, 2023
@jmprieur jmprieur deleted the francofung/updating_lang_version branch October 12, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use langversion 11

3 participants