Conversation
macOS, ROPC will call MSAL C++ logic.
bgavrilMS
approved these changes
Jun 18, 2024
Contributor
|
Sorry, @fengga , my bad, I forgot to mention that, in general, all broker-relevant changes must be tested locally, rather than solely rely on the test pipeline, because we did not figure out a way to install broker into MSAL Python's current pipeline. (You may also tackle how to setup broker in test pipeline, but no need to do it in this PR.) In this particular case, since your one-liner change was reverting a previous change, you could also have use Github's blame feature to find the previous change's PR and realize that there was a test case there. That test case is now failing because we changed the implementation now. Please come up with a new PR (can be in this same branch) to adjust that test case, too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If use_broker enabled, ROPC flows on windows will call into WAM, on macOS will call MSAL C++ logic.