Token revocation for service fabric #943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR missed the updated App Service new API version. |
Avery-Dunn
reviewed
Apr 23, 2025
msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/TokenRevocationUtil.java
Outdated
Show resolved
Hide resolved
Avery-Dunn
reviewed
Apr 23, 2025
gladjohn
reviewed
May 8, 2025
msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/ServiceFabricManagedIdentitySource.java
Show resolved
Hide resolved
gladjohn
approved these changes
May 8, 2025
Contributor
gladjohn
left a comment
There was a problem hiding this comment.
Looks good Neha. Just one clarification comment.
Avery-Dunn
reviewed
May 8, 2025
Avery-Dunn
reviewed
May 8, 2025
msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/ManagedIdentityParameters.java
Show resolved
Hide resolved
Avery-Dunn
reviewed
May 8, 2025
msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/StringHelper.java
Outdated
Show resolved
Hide resolved
Avery-Dunn
reviewed
May 8, 2025
msal4j-sdk/src/test/java/com/microsoft/aad/msal4j/ManagedIdentityTests.java
Outdated
Show resolved
Hide resolved
…ityParameters.java Co-authored-by: Avery-Dunn <62066438+Avery-Dunn@users.noreply.github.com>
Avery-Dunn
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started this PR with AI generated code.
Updated manually after updating the tests to validate the query params