Thought I'd see what the CI thought of this change...

So, it looks like this is failing on py27 as it's installing portalocker-2.3.0

I'm not a pip expert (as I use mamba) but it appears that portalocker is missing a python-requires:

• https://github.com/WoLpH/portalocker/blob/develop/setup.py#L108-L150

The classifiers imply it works on any Python >=3.3 but I think the correct way to prevent pip from installing version 2.3.0 alongside py27 is to specify python_requires='>=3.3'. Failing that restriction in the upstream repo we'd have to specify that here.

Packaging is hard! 🥴

The classifiers imply it works on any Python >=3.3

The classifiers even incorrectly included Python 2, until I send out a PR there, which got merged in 6 hours ago. :-)

but I think the correct way to prevent pip from installing version 2.3.0 alongside py27 is to specify python_requires='>=3.3'.

Thanks for the hint. I also send out another PR there.

Failing that restriction in the upstream repo we'd have to specify that here.

This is also true. And we can probably do it by Environment Markers. Not sure whether we can chain multiple markers, though:

"portalocker~=1.6;platform_system=='Windows';python_version<'3'",
"portalocker>=1.6,<3;platform_system=='Windows';python_version>='3'",

Packaging is hard!

Can't agree more! 🥴