[teamshow]: refactor teamshow to use state db information#1049
Merged
lguohan merged 3 commits intosonic-net:masterfrom Aug 12, 2020
Merged
[teamshow]: refactor teamshow to use state db information#1049lguohan merged 3 commits intosonic-net:masterfrom
lguohan merged 3 commits intosonic-net:masterfrom
Conversation
previously, teamshow needs to read data from teamdctl command output. As teamdmon daemon has been developed to put data into state db. Now, teamshow can get data from state db. Also remove teamshow command and incoporate as part of show command. Also add extensive unit tests Signed-off-by: Guohan Lu <lguohan@gmail.com>
|
This pull request introduces 5 alerts when merging 40899c9bdc6e1d6362e8e5742db93e037c8191bb into 91986b7 - view on LGTM.com new alerts:
|
jleveque
reviewed
Aug 12, 2020
Signed-off-by: Guohan Lu <lguohan@gmail.com>
jleveque
approved these changes
Aug 12, 2020
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
previously, teamshow needs to read data from teamdctl command
output. As teamdmon daemon has been developed to put data into
state db. Now, teamshow can get data from state db.
Also remove teamshow command and incoporate as part of show
command.
Also add extensive unit tests
Signed-off-by: Guohan Lu lguohan@gmail.com
- How I did it
let teamshow read data from state db
- How to verify it
unit test and dut test
coverage
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)