Python 3 compliance#1043
Merged
jleveque merged 7 commits intosonic-net:masterfrom Aug 11, 2020
jleveque:python3_compliance
Merged
Python 3 compliance#1043jleveque merged 7 commits intosonic-net:masterfrom jleveque:python3_compliance
jleveque merged 7 commits intosonic-net:masterfrom
jleveque:python3_compliance
Conversation
|
This pull request introduces 1 alert when merging 3d093ec into 0225c09 - view on LGTM.com new alerts:
|
Contributor
|
not sure why the build fails here. |
qiluo-msft
reviewed
Aug 11, 2020
lguohan
previously approved these changes
Aug 11, 2020
Contributor
Author
It looks like Not sure why we just started seeing this failure on this PR, though; it should have existed. Edit: Fix here: #1045 Strange, but the retest passed, even though I was able to reproduce this issue locally... |
qiluo-msft
approved these changes
Aug 11, 2020
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the migration from Python 2 to Python 3, this PR ensures that all Python files in sonic-utilities are Python 3-compliant, and work with both Python 2 and Python 3.
Once this is merged, we can begin building a Python 3-based version of the sonic-utilities package.