[sonic_platform_common/fan]add fan direction "not applicable"#67
Merged
jleveque merged 2 commits intosonic-net:masterfrom Dec 4, 2019
Merged
[sonic_platform_common/fan]add fan direction "not applicable"#67jleveque merged 2 commits intosonic-net:masterfrom
jleveque merged 2 commits intosonic-net:masterfrom
Conversation
it is for the devices that don't support fetching fan's direction for now
This was referenced Nov 21, 2019
keboliu
approved these changes
Nov 26, 2019
jleveque
approved these changes
Dec 3, 2019
jleveque
suggested changes
Dec 3, 2019
sonic_platform_base/fan_base.py
Outdated
| # Possible fan directions (relative to port-side of device) | ||
| FAN_DIRECTION_INTAKE = "intake" | ||
| FAN_DIRECTION_EXHAUST = "exhaust" | ||
| FAN_DIRECTION_NOT_APPLICABLE = "not applicable" |
Contributor
There was a problem hiding this comment.
Maybe make the string N/A to be more brief?
Collaborator
Author
There was a problem hiding this comment.
Maybe make the string
N/Ato be more brief?
Updated.
jleveque
approved these changes
Dec 4, 2019
abdosi
pushed a commit
that referenced
this pull request
Jan 3, 2020
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
Currently when there is an error event in xcvrd within SFP state machine, it returns with 0 exit code. With this change the SFP if it has an error event with return with non-zero exit code. Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[sonic_platform_common/fan]add fan direction "not applicable"
it is for the devices that don't support fetching fan's direction for now