Skip to content

[YANG] Add trap flow counter to yang model#9353

Merged
prsunny merged 1 commit intosonic-net:masterfrom
Junchao-Mellanox:flow-counter-yang
Dec 1, 2021
Merged

[YANG] Add trap flow counter to yang model#9353
prsunny merged 1 commit intosonic-net:masterfrom
Junchao-Mellanox:flow-counter-yang

Conversation

@Junchao-Mellanox
Copy link
Copy Markdown
Collaborator

Why I did it

Add trap flow counter to yang model

How I did it

Add a new container for yang model and add unit test config

How to verify it

Build

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@dgsudharsan
Copy link
Copy Markdown
Collaborator

@praveen-li Can you please sign off?

@dgsudharsan
Copy link
Copy Markdown
Collaborator

@praveen-li @qiluo-msft Can you please review?

Copy link
Copy Markdown
Member

@praveen-li praveen-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, name change is a suggestion, but I am not sure if backend code is already merged.

Comment thread src/sonic-yang-models/yang-models/sonic-flex_counter.yang
@prsunny prsunny merged commit 06a61de into sonic-net:master Dec 1, 2021
@Junchao-Mellanox Junchao-Mellanox deleted the flow-counter-yang branch December 1, 2021 06:13
@Junchao-Mellanox Junchao-Mellanox added the Request for 202111 Branch For PRs being requested for 202111 branch label Dec 8, 2021
@judyjoseph
Copy link
Copy Markdown
Contributor

Please raise a new PR for 202111 branch, as this patch cannot be cleanly cherry-picked.

@Junchao-Mellanox Junchao-Mellanox removed the Request for 202111 Branch For PRs being requested for 202111 branch label Jan 5, 2022
@Junchao-Mellanox
Copy link
Copy Markdown
Collaborator Author

This change is already in 202111.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants