[enable counters] enable RIF flex counter by default#4655
Merged
lguohan merged 1 commit intosonic-net:masterfrom Jun 4, 2020
Merged
[enable counters] enable RIF flex counter by default#4655lguohan merged 1 commit intosonic-net:masterfrom
lguohan merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
Collaborator
in this case, will be be better if the status shows "not supported"? |
Collaborator
Author
The Flex Counter does not signal which counter is supported/not supported back to DB. It only produces warning log. I don't think we can implement something like this without a "system capabilities" mechanism in place. |
lguohan
approved these changes
Jun 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mykola Faryma mykolaf@mellanox.com
- Why I did it
We need RIF counters to be enabled by default. Flex Counter does probe for supported counters. If a platform does not support RIF counters, SAI will return NOT_SUPPORTED and Flex Counter will stop polling the counter.
- How I did it
- How to verify it
After fresh install rif counter gropup is enabled by default:
- Description for the changelog
enable
RIFflex counter group by default- A picture of a cute animal (not mandatory but encouraged)