refactor: cleanup GH gql query#100
Merged
OliverMKing merged 5 commits intoAzure:mainfrom Oct 27, 2022
Merged
Conversation
This updates the graphql query used to fetch releases by: - returning only the first 10 - ordering them in reverse by created_at This is better because it does not rely on the default ordering by the GitHub graphql API. Co-authored-by: Pieter Van der Haegen <vdhpieter@outlook.com>
OliverMKing
previously approved these changes
Oct 25, 2022
Contributor
|
LGTM. Thanks for the PR. |
sverweij
reviewed
Oct 26, 2022
sverweij
reviewed
Oct 26, 2022
Closed
1 task
Co-authored-by: Sander Verweij <sverweij@users.noreply.github.com>
Co-authored-by: Sander Verweij <sverweij@users.noreply.github.com>
OliverMKing
approved these changes
Oct 26, 2022
Contributor
1 task
dkrantsberg
approved these changes
Oct 27, 2022
Contributor
Author
|
Team work makes the dream work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the graphql query used to fetch releases by:
This is better because it does not rely on the default ordering by the GitHub graphql API.
Co-authored-by: Pieter Van der Haegen @vdhpieter
Testing Plan
I ran this query through the GitHub API explorer here: