Remove caseInsensitive filter operator added back by incorrect merge#2780
Merged
Remove caseInsensitive filter operator added back by incorrect merge#2780
Conversation
caseInsensitive filter operator is not implemented in the resolvers leading to runtime error when used. Including it in schema seems to be an oversight. Removing it for schema generated until we have an approach defined for case insensitive comparisons with different source types Relevant issue #2280
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the caseInsensitive filter operator from the GraphQL schema that was incorrectly added back through a bad merge. The operator was causing runtime errors because it lacks implementation in the resolvers, and this change aligns with the intended fix from PR #2348.
- Removes
caseInsensitivefilter operator definitions and constants - Eliminates the operator from the string filter field definitions
- Prevents runtime errors when users attempt to use the unimplemented operator
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
rusamant
approved these changes
Jul 21, 2025
Alekhya-Polavarapu
approved these changes
Jul 21, 2025
Contributor
|
just a suggestion, may be a negative test case might help here, so that no one else adds this unknowingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
caseInsensitive filter operator is not implemented in the resolvers leading to runtime error when used. Including it in schema seems to be an oversight. Removing it for schema generated until we have an approach defined for case insensitive comparisons with different source types
Relevant issue #2280
This was already addressed in PR #2607
but was readded unintentionally by https://github.com/Azure/data-api-builder/pull/2348/files#diff-f74a036f2a72f2b3f2642c66613b149c5dca7a9696859a26d4ce95863c124d9f
What is this change?
Remove caseInsensitive filter operator from schema generated
How was this tested?