DSC requires the apiVersion field and it's no longer being emitted#18365
Merged
anthony-c-martin merged 1 commit intoAzure:mainfrom Oct 29, 2025
Merged
DSC requires the apiVersion field and it's no longer being emitted#18365anthony-c-martin merged 1 commit intoAzure:mainfrom
apiVersion field and it's no longer being emitted#18365anthony-c-martin merged 1 commit intoAzure:mainfrom
Conversation
So check if that's the scope, and if so, emit it and the type, instead of the formatted name.
| } | ||
|
|
||
| if (metadata.IsAzResource || | ||
| Context.SemanticModel.TargetScope == ResourceScope.DesiredStateConfiguration || |
Member
There was a problem hiding this comment.
I think it would be a good idea to start a test file similar to https://github.com/Azure/bicep/blob/main/src/Bicep.Core.IntegrationTests/Extensibility/RadiusCompatibilityTests.cs (which was initially created to make sure we maintain compatibility with Radius - to make sure that we don't regress this in future.
Happy to merge this change without it as it's ultimately an experimental feature, but just be aware that you do run the risk of getting accidentally broken again if you don't have a way to assert compatibility.
anthony-c-martin
approved these changes
Oct 29, 2025
Contributor
|
Test this change out locally with the following install scripts (Action run 18924778841) VSCode
Azure CLI
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So check if that's the scope, and if so, emit it and the type, instead of the formatted name.
I tested that this reverts to the necessary behavior for DSC's expectations by using
"moduleExtensionConfigs": true.Microsoft Reviewers: Open in CodeFlow