Attempt to purge all vaults, managed HSMs by heaths · Pull Request #1912 · Azure/azure-sdk-tools

heaths · 2021-08-16T21:51:47Z

Reverts #1910. Vaults and managed HSMs are automatically purged on their purge date. The point was to purge them daily to preserve capacity. The default purge date is +90 days.

heaths · 2021-08-16T21:55:30Z

/azp run live-test-resource-cleanup

azure-pipelines · 2021-08-16T21:55:35Z

No pipelines are associated with this pull request.

azure-sdk · 2021-08-16T21:56:10Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

weshaggard · 2021-08-16T22:02:31Z

/azp run automation - live-test-resource-cleanup

azure-pipelines · 2021-08-16T22:02:40Z

Azure Pipelines successfully started running 1 pipeline(s).

weshaggard · 2021-08-16T22:52:31Z

  )
  $purgeableResources = @()

+  # Discover Managed HSMs first since they are a premium resource.


It might not be worth pushing this change to all the other repos but if you want to do it locally until we get through the list that is fine but I leave it up to you.

heaths · 2021-08-17T00:41:50Z

/azp run automation - live-test-resource-cleanup

azure-pipelines · 2021-08-17T00:41:58Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-sdk · 2021-08-17T00:45:11Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

heaths · 2021-08-17T00:53:34Z

/azp run automation - live-test-resource-cleanup

azure-pipelines · 2021-08-17T00:53:42Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-sdk · 2021-08-17T00:57:51Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

heaths · 2021-08-17T01:01:07Z

/azp run automation - live-test-resource-cleanup

azure-pipelines · 2021-08-17T01:01:16Z

Azure Pipelines successfully started running 1 pipeline(s).

heaths · 2021-08-17T01:32:30Z

/azp run automation - live-test-resource-cleanup

azure-pipelines · 2021-08-17T01:32:39Z

Azure Pipelines successfully started running 1 pipeline(s).

heaths · 2021-08-17T01:33:06Z

/azp run automation - live-test-resource-cleanup

azure-pipelines · 2021-08-17T01:33:15Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-sdk · 2021-08-17T01:37:10Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Added comment to new code explaining why, since ScriptBlock.GetNewClosure() is not working as expected.

heaths · 2021-08-17T04:27:42Z

/azp run automation - live-test-resource-cleanup

azure-pipelines · 2021-08-17T04:27:51Z

Azure Pipelines successfully started running 1 pipeline(s).

Resolves #1917

azure-sdk · 2021-08-18T02:48:25Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

heaths · 2021-08-18T02:50:54Z

/azp run automation - live-test-resource-cleanup

azure-pipelines · 2021-08-18T02:51:03Z

Azure Pipelines successfully started running 1 pipeline(s).

heaths · 2021-08-18T04:21:44Z

/azp run automation - live-test-resource-cleanup

azure-pipelines · 2021-08-18T04:21:53Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-sdk · 2021-08-18T04:25:11Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

heaths · 2021-08-18T14:48:41Z

/azp run automation - live-test-resource-cleanup

azure-pipelines · 2021-08-18T14:48:53Z

Azure Pipelines successfully started running 1 pipeline(s).

heaths · 2021-08-18T17:12:46Z

I'm proceeding with the eng/common merge.

ghost · 2021-08-18T20:23:46Z

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

Attempt to purge all vaults, managed HSMs

df8d32f

Reverts #1910. Vaults and managed HSMs are automatically purged on their purge date. The point was to purge them daily to preserve capacity. The default purge date is +90 days.

heaths requested a review from a team as a code owner August 16, 2021 21:51

heaths requested a review from weshaggard August 16, 2021 21:51

weshaggard reviewed Aug 16, 2021

View reviewed changes

Comment thread eng/scripts/live-test-resource-cleanup.ps1 Outdated

weshaggard reviewed Aug 16, 2021

View reviewed changes

heaths added 2 commits August 16, 2021 17:39

Add timeout and more logging

a2cd5b3

Fix typo in comment

8e49250

Pass required -Resource

c0f1665

Fix log message

98bdcc7

Ensure the $Resource is correctly captured

9e3fb03

Added comment to new code explaining why, since ScriptBlock.GetNewClosure() is not working as expected.

heaths mentioned this pull request Aug 17, 2021

DeleteAfterHours=48 is too aggressive for local development #1917

Closed

heaths added 2 commits August 17, 2021 16:39

Resolve PR feedback

dd769cb

Change default DeleteAfterHours to 120

9e1a727

Resolves #1917

heaths requested a review from danieljurek as a code owner August 18, 2021 02:43

heaths linked an issue Aug 18, 2021 that may be closed by this pull request

DeleteAfterHours=48 is too aggressive for local development #1917

Closed

heaths mentioned this pull request Aug 18, 2021

Az cmdlets should allow any network operations to be timed out. Azure/azure-cli#19256

Closed

Use the Az cmdlets built-in -AsJob

c4eb068

azure-sdk added the auto-merge label Aug 18, 2021

ghost merged commit c23ca9d into main Aug 18, 2021

ghost deleted the keyvault-cleanup branch August 18, 2021 20:25

heaths mentioned this pull request Sep 3, 2021

WIP: Purge Managed HSMs after deletion Azure/azure-sdk-for-net#22663

Closed

This pull request was closed.

Conversation

heaths commented Aug 16, 2021

Uh oh!

heaths commented Aug 16, 2021

Uh oh!

azure-pipelines Bot commented Aug 16, 2021

Uh oh!

azure-sdk commented Aug 16, 2021

Uh oh!

weshaggard commented Aug 16, 2021

Uh oh!

azure-pipelines Bot commented Aug 16, 2021

Uh oh!

Uh oh!

weshaggard Aug 16, 2021

Choose a reason for hiding this comment

Uh oh!

heaths commented Aug 17, 2021

Uh oh!

azure-pipelines Bot commented Aug 17, 2021

Uh oh!

azure-sdk commented Aug 17, 2021

Uh oh!

heaths commented Aug 17, 2021

Uh oh!

azure-pipelines Bot commented Aug 17, 2021

Uh oh!

azure-sdk commented Aug 17, 2021

Uh oh!

heaths commented Aug 17, 2021

Uh oh!

azure-pipelines Bot commented Aug 17, 2021

Uh oh!

heaths commented Aug 17, 2021

Uh oh!

azure-pipelines Bot commented Aug 17, 2021

Uh oh!

heaths commented Aug 17, 2021

Uh oh!

azure-pipelines Bot commented Aug 17, 2021

Uh oh!

azure-sdk commented Aug 17, 2021

Uh oh!

heaths commented Aug 17, 2021

Uh oh!

azure-pipelines Bot commented Aug 17, 2021

Uh oh!

azure-sdk commented Aug 18, 2021

Uh oh!

heaths commented Aug 18, 2021

Uh oh!

azure-pipelines Bot commented Aug 18, 2021

Uh oh!

heaths commented Aug 18, 2021

Uh oh!

azure-pipelines Bot commented Aug 18, 2021

Uh oh!

azure-sdk commented Aug 18, 2021

Uh oh!

heaths commented Aug 18, 2021

Uh oh!

azure-pipelines Bot commented Aug 18, 2021

Uh oh!

heaths commented Aug 18, 2021

Uh oh!

ghost commented Aug 18, 2021

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.