Skip to content

Use a helper function to normalize the package name for readme#1353

Merged
4 commits merged intoAzure:masterfrom
sima-zhu:strip_first_azure
Feb 2, 2021
Merged

Use a helper function to normalize the package name for readme#1353
4 commits merged intoAzure:masterfrom
sima-zhu:strip_first_azure

Conversation

@sima-zhu
Copy link
Copy Markdown
Contributor

@sima-zhu sima-zhu commented Jan 28, 2021 •
edited
Loading

@sima-zhu sima-zhu requested a review from a team as a code owner January 28, 2021 18:36
@azure-sdk
Copy link
Copy Markdown
Collaborator

azure-sdk commented Jan 28, 2021

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@sima-zhu sima-zhu requested review from danieljurek, scbedd and weshaggard and removed request for a team January 28, 2021 18:58
@mitchdenny
Copy link
Copy Markdown
Contributor

mitchdenny commented Jan 29, 2021

I might have missed something. Why do we need to do this?

weshaggard
weshaggard reviewed Jan 29, 2021
View reviewed changes
Comment thread eng/common/scripts/update-docs-metadata.ps1 Outdated
@sima-zhu
Copy link
Copy Markdown
Contributor Author

sima-zhu commented Feb 1, 2021

I might have missed something. Why do we need to do this?

@mitchdenny
The original regex stripped out extra stuff. E.g azure-opentelemetry-exporter-azure-monitor instead of having opentelemetry-exporter-azure-monitor-preview.md, we got the opentelemetry-exporter-monitor-preview.md, which breaks the urls link checker in azure-sdk.

The PR here is to use the helper function in Language-Setting.ps1, so we don't handle all lang cases in one statement like before.

@sima-zhu sima-zhu requested a review from weshaggard February 1, 2021 22:31
@azure-sdk
Copy link
Copy Markdown
Collaborator

azure-sdk commented Feb 1, 2021

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Copy Markdown
Collaborator

azure-sdk commented Feb 2, 2021

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

weshaggard
weshaggard reviewed Feb 2, 2021
View reviewed changes
Comment thread eng/common/scripts/artifact-metadata-parsing.ps1 Outdated
@sima-zhu @weshaggard
Update eng/common/scripts/artifact-metadata-parsing.ps1
12e0698 
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
@azure-sdk
Copy link
Copy Markdown
Collaborator

azure-sdk commented Feb 2, 2021

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Feb 2, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ghost
Copy link
Copy Markdown

ghost commented Feb 2, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 686467a into Azure:master Feb 2, 2021
@sima-zhu sima-zhu deleted the strip_first_azure branch February 2, 2021 02:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weshaggard weshaggard weshaggard approved these changes

@danieljurek danieljurek Awaiting requested review from danieljurek

@scbedd scbedd Awaiting requested review from scbedd

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sima-zhu @azure-sdk @mitchdenny @danieljurek @weshaggard