Support client certificate passwords#9434
Merged
Conversation
0ca804f to
39172ad
Compare
bryevdv
previously approved these changes
Jan 13, 2020
Contributor
|
LGTM I wonder if the checked-in test PEM file will trigger some audit somewhere. |
Member
Author
I expect it will, eventually. I'll argue for an exemption. The certs are self-signed and don't authenticate anything, and coverage here is important. |
xiangyan99
reviewed
Jan 28, 2020
xiangyan99
reviewed
Jan 28, 2020
xiangyan99
approved these changes
Jan 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5764 by adding a
passwordkeyword argument toCertificateCredential.