Fix HTTP tracing suppression in agents GA#41361
Merged
lmolkova merged 1 commit intoAzure:feature/azure-ai-agents/1.0.1from Jun 2, 2025
Merged
Fix HTTP tracing suppression in agents GA#41361lmolkova merged 1 commit intoAzure:feature/azure-ai-agents/1.0.1from
lmolkova merged 1 commit intoAzure:feature/azure-ai-agents/1.0.1from
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes double HTTP tracing in agents for the GA version, while also introducing minor improvements in naming, instrumentation, and asynchronous function tool execution.
- Update package display name for consistency
- Replace iterative tool call execution with concurrent calls using asyncio.gather in sample files
- Update telemetry instrumentation to properly use span context and add tracing for create_thread_and_run
- Bump version and update CHANGELOG
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/ai/azure-ai-agents/setup.py | Corrected display name capitalization |
| sdk/ai/azure-ai-agents/samples/agents_async/sample_agents_stream_eventhandler_with_functions_async.py | Revised tool call execution to use AsyncToolSet and concurrent execution |
| sdk/ai/azure-ai-agents/samples/agents_async/sample_agents_functions_async.py | Revised tool call execution to use AsyncToolSet and concurrent execution |
| sdk/ai/azure-ai-agents/azure/ai/agents/telemetry/_ai_agents_instrumentor.py | Modified span context usage and added instrumentation for create_thread_and_run |
| sdk/ai/azure-ai-agents/azure/ai/agents/models/_patch.py | Updated asynchronous execution of tool calls with asyncio.gather |
| sdk/ai/azure-ai-agents/azure/ai/agents/_version.py | Bumped version |
| sdk/ai/azure-ai-agents/CHANGELOG.md | Updated changelog with brief release notes |
Comments suppressed due to low confidence (2)
sdk/ai/azure-ai-agents/azure/ai/agents/telemetry/_ai_agents_instrumentor.py:1475
- Consider adding automated tests to verify the telemetry instrumentation for 'AgentsClient.create_thread_and_run' to ensure the new context changes work as expected in both sync and async flows.
if class_function_name.startswith("AgentsClient.create_thread_and_run"):
sdk/ai/azure-ai-agents/samples/agents_async/sample_agents_stream_eventhandler_with_functions_async.py:49
- Please confirm that the 'add' method on AsyncToolSet is supported and documented, ensuring consistency with its usage in other parts of the SDK.
toolset.add(functions)
9247ed3
into
Azure:feature/azure-ai-agents/1.0.1
26 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extracted from #41341 - fixing double-http-tracing in agents ga version