Skip to content

[ML] Support QueueSettings in AutoML and Sweep jobs#29204

Merged
luigiw merged 27 commits intoAzure:mainfrom
vivijay91:vivijay/serverless_automl
Mar 9, 2023
Merged

[ML] Support QueueSettings in AutoML and Sweep jobs#29204
luigiw merged 27 commits intoAzure:mainfrom
vivijay91:vivijay/serverless_automl

Conversation

@vivijay91
Copy link
Copy Markdown
Contributor

@vivijay91 vivijay91 commented Mar 8, 2023

Description

Add QueueSettings entity on AutoML and Sweep jobs

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Copy Markdown
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-ml

@novaturient95
Copy link
Copy Markdown
Member

test_job_operations is using Oct23 API

image

which is used in following test which is failing in all the workflows:

image

@vivijay91 vivijay91 force-pushed the vivijay/serverless_automl branch from c903765 to b446cfc Compare March 8, 2023 21:56
@luigiw
Copy link
Copy Markdown
Contributor

luigiw commented Mar 8, 2023

You'll need to add queue_settings to automl builder functions too. E.g. https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/ml/azure-ai-ml/azure/ai/ml/automl/_automl_image.py

@luigiw
Copy link
Copy Markdown
Contributor

luigiw commented Mar 8, 2023

A couple of other things,

  1. Add a changelog.
  2. Update docstrings of the classes you modified.
  3. For sweep job, you'll need to add queue_settings to the sweep() function too. https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/ml/azure-ai-ml/azure/ai/ml/entities/_builders/command.py#L396

@vivijay91 vivijay91 changed the title Support QueueSettings in AutoML and Sweep jobs [ML] Support QueueSettings in AutoML and Sweep jobs Mar 8, 2023
@luigiw luigiw merged commit 6fa5045 into Azure:main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants